-
Notifications
You must be signed in to change notification settings - Fork 43
Closed
Labels
status: accepting prsPlease, send a pull request to resolve this!Please, send a pull request to resolve this!type: bugSomething isn't working :(Something isn't working :(
Description
Bug Report Checklist
- I have tried restarting my IDE and the issue persists.
- I have pulled the latest
mainbranch of the repository. - I have searched for related issues and found none that matched my issue.
Expected
dedent("\\nu") should return the string unchanged.
Actual
dedent("\\nu") turns the \\n into a newline, i.e. returns a newline character + u.
Additional Info
This happens because result.replace(/\\n/g, "\n") is called regardless of the value of escapeSpecialCharacters, i.e. regardless of whether dedent is called as a tag on a template or as a function on a string.
An easy fix would be to make the replacement conditional, solving this particular problem. (However, it would still not work for dedent`\\nu` because here, still the \\n would be replaced 🤷♂️)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
status: accepting prsPlease, send a pull request to resolve this!Please, send a pull request to resolve this!type: bugSomething isn't working :(Something isn't working :(