merging in the new postgres methods #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix JSON encoding for PersistValue * Fix JSON encoding * remove uses, deprecation warning disablers * changelog
* Add Editor Tooling Files * Add PR template for style * notes and docs
…#1222) * initial implementation of the upsertWhere * whoops don't commit that * don't export this * updating docs and changelog * remove redundant code * omg hls led me astray * refactoring the connection, updating the changelog, and running stylish :) * continue on errors * put it in the wrong place i don't actually know yaml * jeez maybe this works * maybe it should go here instead * test this on CI * testing a different DB * preparing for the PR * yikes idk what i updated these haddocks incorrectly * Update persistent-postgresql/Database/Persist/Postgresql.hs Co-authored-by: Matt Parsons <parsonsmatt@gmail.com> * moving a postgres-specific util to its own module, other code review ffedback * one last test is failing but I'd love external input on why * last changes * Update persistent-postgresql/Database/Persist/Postgresql.hs Co-authored-by: Matt Parsons <parsonsmatt@gmail.com> * hmmmm I'm close i thinkg * generalized the postgresql changes to PersistQuery * finished implementation, added more tests, removed all todos * haddock update * finishing the rest of the haddocks * don't need to touch Raw * remodeled the data * Update persistent-postgresql/Database/Persist/Postgresql.hs Co-authored-by: Matt Parsons <parsonsmatt@gmail.com> * Update persistent-postgresql/Database/Persist/Postgresql.hs Co-authored-by: Matt Parsons <parsonsmatt@gmail.com> * Update persistent-postgresql/Database/Persist/Postgresql.hs Co-authored-by: Matt Parsons <parsonsmatt@gmail.com> * fix formatting * latest changes real quick * this should all compile but there's no sum type yet. Just taking stock of what we have * remove debug logs * add sum type todo * this should work * we got the tests rocking! * add an assertion to the mysql test * ooops gotta update the mysql test to make it correct * omg DERP * updating tests and also re-running CI Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
* persistent-2.12.1.0 * stylish haskell * bump version numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog