adding upsertWhere and upsertManyWhere to persistent-postgresql
#1222
Conversation
upsertWhere and upsertManyWhereupsertWhere and upsertManyWhere to persistent-postgresql
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
| -- | ||
| -- -- @since 2.12.1.0 | ||
| upsertManyWhere :: | ||
| forall record backend m. |
There was a problem hiding this comment.
so the project does use 4 space indentation - could you get that done?
(on master I've created .editorconfig and .stylish-haskell.yaml files which will help make that easier)
There was a problem hiding this comment.
oh my bad, I tried running stylish-haskell before pushing; I'll try again.
There was a problem hiding this comment.
stylish-haskell won't do formatting changes like that :\ It's fine to leave as-is, it can ge trefactored later.
| {-# LANGUAGE OverloadedStrings #-} | ||
|
|
||
| module Database.Persist.Postgresql.Util ( | ||
| mkPostgresUpdateText |
There was a problem hiding this comment.
Since this module only has one function, let's just put it directly in Database.Persist.Postgresql
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
| -- | ||
| -- -- @since 2.12.1.0 | ||
| upsertManyWhere :: | ||
| forall record backend m. |
There was a problem hiding this comment.
stylish-haskell won't do formatting changes like that :\ It's fine to leave as-is, it can ge trefactored later.
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
…k of what we have
| -- `upsertManyWhere` | ||
| -- | ||
| -- @since 2.12.1.0 | ||
| -- TODO: we could probably make a sum type for the `Filter` record that's passed into the `upserWhere` and |
There was a problem hiding this comment.
@parsonsmatt does this TODO say enough/make sense?
|
@parsonsmatt did I address all the changes needed? |
| -- `upsertManyWhere` | ||
| -- | ||
| -- @since 2.12.1.0 | ||
| -- TODO: we could probably make a sum type for the `Filter` record that's passed into the `upserWhere` and |
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
(unreleased)on the Changelog