fix: exclude archived from TotalCount#757
Conversation
|
Hey, thanks for the PR :) |
I had a similar debate, but made the assumption based on prior work. Archived repos are view-only. When I figured out why there was a difference, I couldn't even close the old PR. By default I would expect behavior to match that of GitHub's search. Considering the feature set of gh-dash, "view and take action" I like customizing the behavior to exclude archived repos since they aren't actionable. I could always view those items in GitHub UI if I really wanted to. I'm happy to change behavior and/or update docs! But will wait for your opinion, I'm just a lowly user 😂 . |
|
ok cool makes sense. Let's just add a disclaimer in the docs |
Summary
In #124 and #221, archived repositories were excluded from results because users can't interact with PRs/issues on archived repos. The fixes in #199 and #223 filtered archived repos client-side after fetching results, but the TotalCount returned from GitHub's API still included them, causing a mismatch between the displayed count and actual items.
How did you test this change?
task linttask testImages/Videos
Fixes #756