fix: #124 exclude pull requests of archived repositories#199
Merged
dlvhdr merged 2 commits intodlvhdr:mainfrom Nov 14, 2022
Merged
fix: #124 exclude pull requests of archived repositories#199dlvhdr merged 2 commits intodlvhdr:mainfrom
dlvhdr merged 2 commits intodlvhdr:mainfrom
Conversation
dlvhdr
reviewed
Nov 11, 2022
Owner
dlvhdr
left a comment
There was a problem hiding this comment.
Thanks, this looks great! For a lack of a better solution from github, this is the best we can do.
Comment on lines
+21
to
+24
| Repository: struct { | ||
| NameWithOwner string | ||
| IsArchived bool | ||
| }{ |
Owner
There was a problem hiding this comment.
Can you extract the struct type to a type variable?
Contributor
Author
There was a problem hiding this comment.
Thanks for review! I fixed it, is that ok?
dlvhdr
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have seen this issue. I added a change to exclude PRs in archived repositories.
#124
I would have liked to be able to remove PRs from archived repositories in the Github API arguments, but after checking the documentation I found it difficult to do so. I have added an implementation to remove pull requests from archived repositories after fetching pull requests.
How did you test this change?
I wrote unit tests for the added functions.
I ran the command
gh dashto see if it was successful in removing pull requests from archived repositories.I used this archived repository.
https://github.com/yokishava/k8s-manifest-ci-demo
Images/Videos
before
after