feat: show requested reviewers in PR sidebar#724
Merged
dlvhdr merged 5 commits intodlvhdr:mainfrom Jan 2, 2026
Merged
Conversation
586dd13 to
114d592
Compare
dlvhdr
reviewed
Jan 1, 2026
This change causes a new “reviewers:” line to be displayed in the PR preview pane, just below the author information. Fixes dlvhdr#685. The “reviewers:” display includes: - Review-status icon: - “waiting” icon for pending reviews - “comment” icon, for reviewers who have commented - “success“ icon for approved reviews - “failure” icon for “changes requested” - Reviewer GH name, with @ prefix for users, no prefix for teams - Reviewer-type indicators: - “team icon for reviews requested from GH teams - “owner” icon for code owners In the case of reviews requested from bots: For GH usernames containing "bot", we skip the code-owner icon annotation — since the GH name already makes clear that the reviewer is a bot. The implementation fetches reviewer data via GraphQL using a union type to handle the different reviewer types (User, Team, Bot, Mannequin) — with helper methods to extract display names and determine reviewer types. Closes dlvhdr#685 Added unit tests in internal/tui/components/prview/reviewers_test.go: - Empty review requests - Single user awaiting review - User who commented - Code-owner display - Team reviewer display - Bot reviewer (no extra annotation) - Multiple reviewers - Reviewer who approved - Reviewer who requested changes - Mix of pending reviews and completed reviews
…ents - Move the Reviewers info from header to Overview tab, above Labels - Use common styles (FaintTextStyle, WaitingGlyph, CommentGlyph) - Remove bot string detection — rely solely on GraphQL type - Remove team-icon suffix from team reviewers - Rename hasTeamIcon to hasOwnerIcon for clarity - Add ApprovedIcon and ChangesRequestedIcon to constants - Add wrapping for long reviewer lists - Update tests for new format and add wrapping test
c3b71ac to
d185acd
Compare
Owner
|
@sideshowbarker I made some small style changes which I think look better. Main one being changing the icons to be consistent with GitHub - so no clock :D 
|
dlvhdr
approved these changes
Jan 2, 2026
sideshowbarker
added a commit
to sideshowbarker/gh-dash
that referenced
this pull request
Jan 2, 2026
…ers too This change implements two follow-ups in response to dlvhdr#724 review comments: dlvhdr#724 (comment) dlvhdr#724 (comment) Specifically: - Increases # of reviewers limit from last 5 reviewers to 100 reviewers - Shows “Loading…” state while enriched data is being fetched - Shows “suggested” reviewers (= code owners), even if not yet requested - Shows also those reviewers who only commented (not just approved/rejected)
dlvhdr
pushed a commit
that referenced
this pull request
Jan 3, 2026
…ers too (#728) # Summary This change implements two follow-ups in response to #724 review comments: #724 (comment) #724 (comment) Specifically: - Increases # of reviewers limit from last 5 reviewers to 100 reviewers - Shows “Loading…” state while enriched data is being fetched - Shows “suggested” reviewers (= code owners), even if not yet requested - Shows also those reviewers who only commented (not just approved/rejected) ## How did you test this change? Updated internal/tui/components/prview/reviewers_test.go with new tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change causes a new “reviewers:” line to be displayed in the PR preview pane, just below the author information.
The “reviewers:” display includes:
In the case of reviews requested from bots: For GH usernames containing
bot, we skip the code-owner icon annotation — since the GH name already makes clear that the reviewer is a bot.The implementation fetches reviewer data via GraphQL using a union type to handle the different reviewer types (User, Team, Bot, Mannequin) — with helper methods to extract display names and determine reviewer types.
Closes #685
How did you test this change?
Added unit tests in internal/tui/components/prview/reviewers_test.go:
Images/Videos
“waiting for review” + “changes requested” + “made comments” reviewers
“waiting for review” + “approved” reviewers
“team” + “bot” reviewers
“code owner” reviewers