This repository was archived by the owner on Jan 26, 2024. It is now read-only.
Make sure to not pass NULL surfaces to these wlr functions#8
Merged
djpohly merged 3 commits intodjpohly:masterfrom Jun 14, 2020
Merged
Make sure to not pass NULL surfaces to these wlr functions#8djpohly merged 3 commits intodjpohly:masterfrom
djpohly merged 3 commits intodjpohly:masterfrom
Conversation
Turns out that this will hit asserts that will abort dwl.
djpohly
suggested changes
Jun 13, 2020
Owner
djpohly
left a comment
There was a problem hiding this comment.
Looks like the assertion landed in wlroots last week. PR looks good with the suggested updates.
Owner
|
Thanks! |
Merged
Closed
link2xt
added a commit
to link2xt/dwl
that referenced
this pull request
Nov 19, 2023
…NULL Passing NULL to wlr_keyboard_set_keymap results in a segfault. Example: Thread 1 "dwl" received signal SIGSEGV, Segmentation fault. 0x00007ffff7e49b64 in xkb_keymap_ref () from /usr/lib/libxkbcommon.so.0 (gdb) bt #0 0x00007ffff7e49b64 in xkb_keymap_ref () at /usr/lib/libxkbcommon.so.0 djpohly#1 0x00007ffff7f06389 in wlr_keyboard_set_keymap () at /usr/lib/libwlroots.so.11 djpohly#2 0x000055555555bc54 in createkeyboard () djpohly#3 0x000055555555c283 in inputdevice () djpohly#4 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0 djpohly#5 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0 djpohly#6 0x00007ffff7edb52c in () at /usr/lib/libwlroots.so.11 djpohly#7 0x00007ffff7ee44b6 in () at /usr/lib/libwlroots.so.11 djpohly#8 0x000055555555fe66 in main ()
sevz17
pushed a commit
that referenced
this pull request
Nov 19, 2023
…NULL Passing NULL to wlr_keyboard_set_keymap results in a segfault. Example: Thread 1 "dwl" received signal SIGSEGV, Segmentation fault. 0x00007ffff7e49b64 in xkb_keymap_ref () from /usr/lib/libxkbcommon.so.0 (gdb) bt #0 0x00007ffff7e49b64 in xkb_keymap_ref () at /usr/lib/libxkbcommon.so.0 #1 0x00007ffff7f06389 in wlr_keyboard_set_keymap () at /usr/lib/libwlroots.so.11 #2 0x000055555555bc54 in createkeyboard () #3 0x000055555555c283 in inputdevice () #4 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0 #5 0x00007ffff7e8101e in wl_signal_emit_mutable () at /usr/lib/libwayland-server.so.0 #6 0x00007ffff7edb52c in () at /usr/lib/libwlroots.so.11 #7 0x00007ffff7ee44b6 in () at /usr/lib/libwlroots.so.11 #8 0x000055555555fe66 in main ()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine passing NULL surfaces resulted in aborts.
I am not sure this is the right way to fix these so you should have a closer look at the issue.