Deleted leaking loop iter vars in smartif.py.#20760
Merged
jacobtylerwalls merged 1 commit intodjango:mainfrom Feb 24, 2026
Merged
Deleted leaking loop iter vars in smartif.py.#20760jacobtylerwalls merged 1 commit intodjango:mainfrom
smartif.py.#20760jacobtylerwalls merged 1 commit intodjango:mainfrom
Conversation
While working on https://github.com/typeddjango/django-stubs/pull/3114/changes#diff-c408a224a641ee1ad26789d61b19c64c44667c1feb8fce0d58aea0338844ca66R276-R278 we have noticed that loop variables leak into the module namespace. It has two negative effects: 1. Users can access `smartif.op` and `smartif.key` public attrs, which is clearly not intenteded 2. We in `django-stubs` have to ignore these two objects from annotations Let's remove them :)
ngnpope
approved these changes
Feb 24, 2026
jacobtylerwalls
approved these changes
Feb 24, 2026
MysticEntity-dev
pushed a commit
to MysticEntity-dev/djangodev
that referenced
this pull request
Feb 24, 2026
…d_wsgi auth handler. Refs CVE-2024-39329, django#20760. Thanks Stackered for the report, and Jacob Walls and Markus Holtermann for the reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
nessita
pushed a commit
to nessita/django
that referenced
this pull request
Feb 24, 2026
…() in mod_wsgi auth handler. Refs CVE-2024-39329, django#20760. Thanks Stackered for the report, and Jacob Walls and Markus Holtermann for the reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Backport of 3eb814e from main.
nessita
pushed a commit
to nessita/django
that referenced
this pull request
Mar 2, 2026
…() in mod_wsgi auth handler. Refs CVE-2024-39329, django#20760. Thanks Stackered for the report, and Jacob Walls and Markus Holtermann for the reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Backport of 3eb814e from main.
craigds
pushed a commit
to koordinates/django
that referenced
this pull request
Mar 5, 2026
…() in mod_wsgi auth handler. Refs CVE-2024-39329, django#20760. Thanks Stackered for the report, and Jacob Walls and Markus Holtermann for the reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com> Backport of 3eb814e from main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket number
None, trivial change
Branch description
While working on https://github.com/typeddjango/django-stubs/pull/3114/changes#diff-c408a224a641ee1ad26789d61b19c64c44667c1feb8fce0d58aea0338844ca66R276-R278 we have noticed that loop variables leak into the module namespace.
It has two negative effects:
smartif.opandsmartif.keypublic attrs, which is clearly not intentededdjango-stubshave to ignore these two objects from annotationsLet's remove them :)
AI Assistance Disclosure (REQUIRED)
Checklist
mainbranch.