Refs #32074 -- Removed usage of Python's deprecated distutils.version package.#14240
Merged
felixxm merged 1 commit intodjango:mainfrom Apr 9, 2021
Merged
Refs #32074 -- Removed usage of Python's deprecated distutils.version package.#14240felixxm merged 1 commit intodjango:mainfrom
felixxm merged 1 commit intodjango:mainfrom
Conversation
… package. The distutils package was formally deprecated in Python 3.10 and will be removed in Python 3.12.
carltongibson
approved these changes
Apr 9, 2021
Member
carltongibson
left a comment
There was a problem hiding this comment.
OK, looks fine, and tests in tests/version/tests.py 👍
Thanks
Member
Author
|
@carltongibson Thanks for checking 👍 |
ericsnowcurrently
pushed a commit
to python/pyperformance
that referenced
this pull request
Nov 28, 2022
Fixes #247. Django has a runtime dependency on distutils, so adding setuptools as a dependency resolves it. This has already been resolved upstream [1], but this allows us to keep using the same version of Django for the benchmark. [1] django/django#14240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
distutilspackage was formally deprecated in Python 3.10 and will be removed in Python 3.12.See PEP 632 and distutils.version.LooseVersion.