Refs #31040, Refs #31224 -- Prevented cycles in exceptions chain.#12978
Refs #31040, Refs #31224 -- Prevented cycles in exceptions chain.#12978felixxm merged 1 commit intodjango:masterfrom
Conversation
Exception handling was raising an exception that was creating a cycle in the exception chain (by re-raising an exception that was already being handled). Thanks Chris Jerdonek for detailed analysis.
d9260a7 to
6c38cd9
Compare
|
Great! Are you able to confirm that the test that was hanging with Python3.9.0a6 passes with this change? |
|
Yes it works with this patch. |
|
Looking at the patch: In |
|
process_exception() should return either |
carltongibson
left a comment
There was a problem hiding this comment.
OK, thanks @felixxm.
I might just be inclined to adjust the exended commit message to emphasize that it's sync_to_async that leads has the extra layer.
Async exception handling was raising an exception that was creating a
cycle in the exception chain (by re-raising an exception in
sync_to_async that was already being handled ).
(Up to you!) 👍
|
@carltongibson Thanks for checking 👍 |
Exception handling was raising an exception that was creating a cycle in the exception chain (by re-raising an exception that was already being handled).
Thanks Chris Jerdonek for detailed analysis.
See also https://bugs.python.org/issue40696.