Move manifest package to schema1#912
Merged
aaronlehmann merged 1 commit intodistribution:masterfrom Aug 21, 2015
Merged
Conversation
Collaborator
Author
|
@aaronlehmann PTAL |
2655cfc to
99bb7d2
Compare
There was a problem hiding this comment.
I assume that this is an intermediate step, and eventually methods like this will use abstractions provided by the manifest package, right? Same question for the notifications package.
No objection to doing it this way; just want to confirm that's the path forward.
|
LGTM |
|
LGTM. Will need a rebase though. |
As we begin our march towards multi-arch, we must prepare for the reality of multiple manifest schemas. This is the beginning of a set of changes to facilitate this. We are both moving this package into its target position where it may live peacefully next to other manfiest versions. Signed-off-by: Stephen J Day <stephen.day@docker.com>
99bb7d2 to
6712e60
Compare
Collaborator
Author
|
@RichardScothern @aaronlehmann Rebased. |
aaronlehmann
pushed a commit
that referenced
this pull request
Aug 21, 2015
Move manifest package to schema1
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
…g-schema1 Move manifest package to schema1
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
…g-schema1 Move manifest package to schema1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we begin our march towards multi-arch, we must prepare for the reality of
multiple manifest schemas. This is the beginning of a set of changes to
facilitate this. We are both moving this package into its target position where
it may live peacefully next to other manfiest versions.
Signed-off-by: Stephen J Day stephen.day@docker.com