Merged
Conversation
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
Collaborator
|
This is still causing a diff after diff --git a/docs/spec/api.md b/docs/spec/api.md
index c573178..12c1043 100644
--- a/docs/spec/api.md
+++ b/docs/spec/api.md
@@ -175,7 +175,6 @@ identify a set of modifications.
<li>Added error code for unsupported operations.</li>
</ul>
</dd>
-
</dl>
## Overview
@@ -727,7 +726,8 @@ delete may be issued with the following request format:
DELETE /v2/<name>/blobs/<digest>
-If the blob exists and has been successfully deleted, the following response will be issued:
+If the blob exists and has been successfully deleted, the following response
+will be issued:
202 Accepted
Content-Length: None
@@ -735,6 +735,8 @@ If the blob exists and has been successfully deleted, the following response wil
If the blob had already been deleted or did not exist, a `404 Not Found`
response will be issued instead.
+If a layer is deleted which is referenced by a manifest in the registry,
+then the complete images will not be resolvable.
#### Pushing an Image Manifest
@@ -1022,7 +1024,6 @@ A list of methods and URIs are covered in the table below:
| PUT | `/v2/<name>/blobs/uploads/<uuid>` | Blob Upload | Complete the upload specified by `uuid`, optionally appending the body as the final chunk. |
| DELETE | `/v2/<name>/blobs/uploads/<uuid>` | Blob Upload | Cancel outstanding upload processes, releasing associated resources. If this is not called, the unfinished uploads will eventually timeout. |
| GET | `/v2/_catalog` | Catalog | Retrieve a sorted, json list of repositories available in the registry. |
-| DELETE | `/v2/<name>/blobs/<digest>` | Blob delete | Delete the blob identified by `name` and `digest`|
The detail for each endpoint is covered in the following sections.
@@ -1732,7 +1733,6 @@ The error codes that may be included in the response body are enumerated below:
#### DELETE Manifest
-
Delete the manifest identified by `name` and `reference`. Note that a manifest can _only_ be deleted by `digest`.
|
Author
|
I see. descriptors.go is missing a section. |
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
Author
|
descriptors.go has been updated. PTAL @stevvooe |
Collaborator
There was a problem hiding this comment.
Small nit: I don't think we return UNSUPPORTED on method not allowed.
Author
There was a problem hiding this comment.
Confirmed:
curl -X DELETE http://localhost:5000/v2/mongo/blobs/sha256:5edccc13a9bd6722232ab891591bf3d19876c60787dce4e091f29bdf60192e98
{"errors":[{"code":"UNSUPPORTED","message":"The operation is unsupported."}]}
Collaborator
|
@RichardScothern Do we know why this dropped out? I am fairly sure we merged this correctly. |
Collaborator
|
LGTM |
Author
|
It's not clear from |
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
Spelling corrections
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
Spelling corrections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Scothern richard.scothern@gmail.com
closes #804