Replace uuid dependency with internal library#556
Merged
stevvooe merged 1 commit intodistribution:masterfrom May 26, 2015
Merged
Replace uuid dependency with internal library#556stevvooe merged 1 commit intodistribution:masterfrom
stevvooe merged 1 commit intodistribution:masterfrom
Conversation
uuid/uuid.go
Outdated
Contributor
There was a problem hiding this comment.
Feels weird to have a logrus dependency in a uuid package. How about having a global variable that defaults to func(msg string) { fmt.Fprintln(os.Stderr, msg) } ? clients can then change it in their init() functions.
d3e1a35 to
583e6bc
Compare
uuid/uuid.go
Outdated
583e6bc to
422a404
Compare
Contributor
|
LGTM |
Collaborator
Author
Collaborator
There was a problem hiding this comment.
Should this error be logged?
Collaborator
Author
There was a problem hiding this comment.
No, this is just a validation.
Collaborator
|
LGTM |
Signed-off-by: Stephen J Day <stephen.day@docker.com>
422a404 to
36e34a5
Compare
Collaborator
Author
|
Added retry backoff and restricted to EPERM. Will panic after 450ms of try to get entropy. |
|
LGTM |
Member
There was a problem hiding this comment.
I don't think the trailing spaces should be here, otherwise you might be testing the wrong thing.
Contributor
|
LGTM |
stevvooe
added a commit
that referenced
this pull request
May 26, 2015
Replace uuid dependency with internal library
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
Replace uuid dependency with internal library
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
Replace uuid dependency with internal library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @tiborvass @dmcgowan
Signed-off-by: Stephen J Day stephen.day@docker.com