Merged
Conversation
the `uuid` package is not used in the code base, so it can be safely remove. Signed-off-by: Alex Gotgelf <gotgelf@gmail.com> Signed-off-by: gotgelf <gotgelf@gmail.com>
b480149 to
bb15625
Compare
Member
corhere
approved these changes
Nov 29, 2023
milosgajdos
approved these changes
Nov 29, 2023
Member
|
Yeah, I get that but I vaguely remember a convo we had about keeping it in the source tree in case someone external depends on it -- for whatever reason -- so we can quickly re-export it or something...I'm ok binning this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
uuidpackage is not used in the code base, insteadgithub.com/google/uuidis used.so it can be safely remove.
It appears that the
uuidpackage currently is not being utilized in the codebase. Insteadgithub.com/google/uuidis used.Given this, it would be safe to remove the unused
uuidpackageFixes: #4043