Switch to github.com/google/uuid#4132
Conversation
dafbd3f to
8f00321
Compare
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
8f00321 to
ef8651e
Compare
That I'm not so sure about. Our bespoke uuid package was introduced in #556 as a replacement of the predecessor to github.com/google/uuid of all things. Apparently backoff-retry on EPERM from the random source was a motivating factor. It probably didn't help that the uuid dependency at the time did this unconditionally: The "github.com/google/uuid".NewString() function is the same: read from the random source or panic. Random-source errors clearly were a problem:
so I am concerned that just doing the equivalent of reverting #556 is going to introduce regressions. Could we wrap google/uuid in the retry logic to retain the existing behaviour? |
|
I vaguely remember reading through that issue. I also found this comment by Stevoo kinda unresolved: Specifically, we never learnt what the real error actually was 🤷♂️ |
We could, but that was back in 2015 and I expect there have been many improvements since then. Most of the places we create a uuid we don't have err in the return, so we couldn't fail more cleanly than panicking too. Without a good understanding of why the workaround was needed, I think its sensible to remove it and see if we get any tickets during our beta period. Just for fun, I created a billion uuids on my laptop using the google library. It took 5m39s and didn't panic once. I know that doesn't recreate whatever issue we had before, but I thought I'd try it. |
corhere
left a comment
There was a problem hiding this comment.
Fair enough; I'm okay with scream-testing if you are
Our own package wasn't adding anything.