feat: add option to disable combining the pending part #3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
hey @huangnauh thanks for the PR; can you please sign your commit as per the contributors guildeines? |
Contributor
Author
Done. PTAL |
Codecov Report
@@ Coverage Diff @@
## main #3556 +/- ##
=======================================
Coverage 56.35% 56.35%
=======================================
Files 101 101
Lines 7307 7307
=======================================
Hits 4118 4118
Misses 2534 2534
Partials 655 655 Continue to review full report at Codecov.
|
Signed-off-by: Libo Huang <huanglibo2010@gmail.com>
milosgajdos
approved these changes
Jan 17, 2022
waynr
approved these changes
Jan 18, 2022
milosgajdos
added a commit
to milosgajdos/distribution
that referenced
this pull request
Dec 18, 2023
This reverts distribution#3556 This feature is currently broken and requires more fundamental changes in the S3 driver. Until then it's better to remove it. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Amazon S3 Compatible Storage only supports the same part size（1M-5G） in the multipart upload, expect for the last part. And the last part must not be larger than the same part size.
We add a option
MultipartCombineSmallPartto enable/disable combining the pending partSigned-off-by: Libo Huang huanglibo2010@gmail.com