docs/spec/manifest-v2-2.md: fix ARM variant#3371
Merged
wy65701436 merged 1 commit intodistribution:mainfrom Mar 4, 2021
Merged
docs/spec/manifest-v2-2.md: fix ARM variant#3371wy65701436 merged 1 commit intodistribution:mainfrom
wy65701436 merged 1 commit intodistribution:mainfrom
Conversation
The correct `vairant` string for ARM v6 is "v6", not "armv6l". There is no known implementation that actually uses "armv6l". See the discussion in opencontainers/image-spec PR 817 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Codecov Report
@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
- Coverage 58.22% 55.84% -2.39%
==========================================
Files 105 102 -3
Lines 8362 7222 -1140
==========================================
- Hits 4869 4033 -836
+ Misses 2836 2552 -284
+ Partials 657 637 -20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
milosgajdos
approved these changes
Mar 2, 2021
dylanrhysscott
pushed a commit
to digitalocean/docker-distribution
that referenced
this pull request
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct
vairantstring for ARM v6 is "v6", not "armv6l".There is no known implementation that actually uses "armv6l".
See the discussion in opencontainers/image-spec#817 (comment)