registry: do not use http.StatusTooManyRequests#1696
Merged
RichardScothern merged 1 commit intodistribution:masterfrom May 4, 2016
Merged
registry: do not use http.StatusTooManyRequests#1696RichardScothern merged 1 commit intodistribution:masterfrom
RichardScothern merged 1 commit intodistribution:masterfrom
Conversation
go1.5 doesn't export http.StatusTooManyRequests while go1.6 does. Fix this by hardcoding the status code for now. Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Current coverage is 54.66%
@@ master #1696 diff @@
==========================================
Files 120 120
Lines 10493 10493
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6456 5736 -720
- Misses 3434 4246 +812
+ Partials 603 511 -92
|
|
I wish we didn't have to support Go 1.5, but I don't see another choice here until Docker finally upgrades, so... LGTM |
|
a regretful LGTM |
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Apr 22, 2021
registry: do not use http.StatusTooManyRequests
thaJeztah
pushed a commit
to thaJeztah/distribution
that referenced
this pull request
Jan 19, 2022
registry: do not use http.StatusTooManyRequests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go1.5 doesn't export http.StatusTooManyRequests while
go1.6 does. Fix this by hardcoding the status code for now.
ping @aaronlehmann @cpuguy83 @icecrime - we probably could update go to 1.6 but....
Signed-off-by: Antonio Murdaca runcom@redhat.com