Conversation
It's backward compatible so still supports our 3.28 ember-source. The visible change is finally getting rid of this message: ``` WARNING: Node v18.12.0 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js. See https://git.io/v7S5n for details. ``` `@ember/source` dependency is added for future compatibility. See: ember-cli/ember-cli#10125
to fix a deprecation warning
# Conflicts: # app/assets/javascripts/yarn.lock
Co-authored-by: David Taylor <david@taylorhq.com>
ChadBoschert
pushed a commit
to apt-crowd/discourse
that referenced
this pull request
Apr 26, 2023
It's backward compatible so still supports our 3.28 ember-source. The visible change is finally getting rid of this message: ``` WARNING: Node v18.12.0 is not tested against Ember CLI on your platform. We recommend that you use the most-recent "Active LTS" version of Node.js. See https://git.io/v7S5n for details. ``` --- `@ember/string` dependency is added for future compatibility. See: ember-cli/ember-cli#10125 --- `tests/helpers/index.js` is unused for now, but is a nice pattern. We could move some of our test setup into local `setupApplicationTest/setupRenderingTest/setupTest` helpers. Co-authored-by: David Taylor <david@taylorhq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's backward compatible so still supports our 3.28 ember-source.
The visible change is finally getting rid of this message:
@ember/stringdependency is added for future compatibility. See: ember-cli/ember-cli#10125tests/helpers/index.jsis unused for now, but is a nice pattern. We could move some of our test setup into localsetupApplicationTest/setupRenderingTest/setupTesthelpers.