Fix: Empty VC & leave/rejoin causes no audio to be heard/played from libdave#3244
Merged
Conversation
6 tasks
kshitijanurag
pushed a commit
to kshitijanurag/Discord.Net
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There were a few issues with the new libdave implementation related to playing audio in an empty VC and when users leave/rejoin
Empty VC causes audio to fail to be encrypted/sent
Fixed by setting the encryptors pass through mode to true when a session is first created, this causes any attempts at encryption before proper initialization to just not happen, fixing a case where the stream would fail with
MissingKeyRatchet.Users joining/leaving leads to no audio heard
Fixed by sending MLS key packages on prepare epoch, like the spec says to, as well as syncing a new users decryptor to the latest sessions state.