Skip to content

[Feature] Modal radio/checkbox groups & checkboxes#3229

Merged
Misha-133 merged 12 commits into
devfrom
feature/modal-radio-buttons-checkboxes
Mar 11, 2026
Merged

[Feature] Modal radio/checkbox groups & checkboxes#3229
Misha-133 merged 12 commits into
devfrom
feature/modal-radio-buttons-checkboxes

Conversation

@Misha-133

@Misha-133 Misha-133 commented Jan 24, 2026

Copy link
Copy Markdown
Member

Yes, this is real too

@github-actions

github-actions Bot commented Jan 24, 2026

Copy link
Copy Markdown

Test Results

  1 files  ±0    1 suites  ±0   0s ⏱️ ±0s
230 tests ±0  230 ✅ ±0  0 💤 ±0  0 ❌ ±0 
237 runs  ±0  237 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a9a125a. ± Comparison against base commit 0dea5bb.

♻️ This comment has been updated with latest results.

@Misha-133 Misha-133 marked this pull request as ready for review March 8, 2026 23:01
@Misha-133 Misha-133 requested review from Cenngo and quinchs March 8, 2026 23:09

@quinchs quinchs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping builders in parity with optional properties (mostly the bools) even though they have defaults is a good idea.

Comment thread src/Discord.Net.Rest/API/Common/CheckboxGroupComponent.cs Outdated
Comment thread src/Discord.Net.Rest/API/Common/RadioGroupComponent.cs Outdated
Comment thread src/Discord.Net.Rest/Extensions/MessageComponentExtension.cs Outdated
Comment thread src/Discord.Net.Rest/Extensions/MessageComponentExtension.cs Outdated
Comment thread src/Discord.Net.Rest/Extensions/MessageComponentExtension.cs Outdated
Misha-133 and others added 3 commits March 9, 2026 13:21
Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
… i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc
@Misha-133 Misha-133 merged commit c0fbefe into dev Mar 11, 2026
3 checks passed
@Misha-133 Misha-133 deleted the feature/modal-radio-buttons-checkboxes branch March 11, 2026 11:38
kshitijanurag pushed a commit to kshitijanurag/Discord.Net that referenced this pull request Mar 20, 2026
* Add models-entities-builders

* working checkbox component

* working checkbox groups

* working radio group

* add missing xmldoc

* fix xmldoc x2

* add more missing xmldocs & fix some logic

* more xmldoc fixes

* I should stop writing code in github's text editor

* Apply suggestions from code review

Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>

* add missing ` ?? Optional<bool>.Unspecified`

* i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc i love xmldoc

---------

Co-authored-by: Quin Lynch <49576606+quinchs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants