Skip to content

chore(deps): k8s.io/cli-runtime@v0.27.2 && k8s.io/client-go@v0.27.2#151

Merged
diranged merged 7 commits intomainfrom
upg
Jun 17, 2023
Merged

chore(deps): k8s.io/cli-runtime@v0.27.2 && k8s.io/client-go@v0.27.2#151
diranged merged 7 commits intomainfrom
upg

Conversation

@diranged
Copy link
Copy Markdown
Owner

@diranged diranged commented Jun 17, 2023

No description provided.

@diranged diranged force-pushed the upg branch 4 times, most recently from 68e81e2 to a0eb274 Compare June 17, 2023 15:39
@coveralls
Copy link
Copy Markdown

coveralls commented Jun 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5299404082

  • 48 of 57 (84.21%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 46.084%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/v1alpha1/exec_access_request_webhook.go 10 11 90.91%
internal/webhook/contextual_defaulter.go 2 4 50.0%
internal/webhook/contextual_validator.go 22 28 78.57%
Files with Coverage Reduction New Missed Lines %
internal/webhook/contextual_validator.go 1 62.12%
Totals Coverage Status
Change from base Build 5298752827: 0.3%
Covered Lines: 959
Relevant Lines: 2081
💛 - Coveralls

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jun 17, 2023
@diranged diranged marked this pull request as ready for review June 17, 2023 18:11
@diranged diranged merged commit 0049093 into main Jun 17, 2023
@diranged diranged deleted the upg branch June 17, 2023 18:12
@diranged diranged mentioned this pull request Aug 16, 2023
Merged
diranged added a commit that referenced this pull request Aug 16, 2023
@diranged
feat(test): introduce a test that executes the validatingwebhook (#168)
df43a3e 
Closes #167.

In #151 we updated some libraries and
we missed the fact that
kubernetes-sigs/controller-runtime#2134 removed
the `InjectDecoder` call entirely. This PR implements a live test of the
`CONNECT` functionality, as well as fixes for the decoder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build github_actions Pull requests that update GitHub Actions code repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diranged @coveralls