Keep elements in standard model immutable from parent-pointer updates#85
Merged
Keep elements in standard model immutable from parent-pointer updates#85
Conversation
Collaborator
|
do we have any issue to justify this change? should we add any test to validate? |
Collaborator
Author
|
I believe this should fix the concurrency issue that Willow raised in email (but they have not yet created an issue for). I don't have a repro of the issue, so I'm not completely sure this will address it, but there is definitely a bug here, so this change is at least an improvement in correctness.
However, the PR is failing the checks. Specifically, the ci.yml action is failing on the docfx step. I don't understand why this is failing. The ADO PR pipeline also runs docfx, but it is passing. And we just ran the apidocs.yml action successfully this morning, and it runs docfx. So I'm quite confused. I don't see anything special that the ci.yml is doing or not doing relative to apidocs.yml.
JD
…________________________________
From: Rido ***@***.***>
Sent: Tuesday, March 7, 2023 12:05 PM
To: digitaltwinconsortium/DTDLParser ***@***.***>
Cc: John (JD) Douceur ***@***.***>; Author ***@***.***>
Subject: Re: [digitaltwinconsortium/DTDLParser] Keep elements in standard model immutable from parent-pointer updates (PR #85)
do we have any issue to justify this change? should we add any test to validate?
—
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdigitaltwinconsortium%2FDTDLParser%2Fpull%2F85%23issuecomment-1458780306&data=05%7C01%7Cjohndo%40microsoft.com%7Cb05d6698c0794be9cf0108db1f474320%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638138163155889410%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=27MER%2B8O%2BmD3hPFrK5iRXpE%2BqvJGtYNBy4z5ThJyYOM%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAZQSEAV4GHQ7T6AFDWL3WTW26IHRANCNFSM6AAAAAAVS4YLAA&data=05%7C01%7Cjohndo%40microsoft.com%7Cb05d6698c0794be9cf0108db1f474320%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638138163155889410%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Cx6mtM2Pt%2BbcE8oyXhAMqtQXUSXUXUb%2B%2Fmve%2BRNNm4o%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Collaborator
Author
|
😄 |
Collaborator
Author
|
Issue #86 is a different manifestation of the issue. It occurs on Parse(), whereas the other form occurs on ParseAsync(). |
jaslawinMs
approved these changes
Mar 9, 2023
rido-min
approved these changes
Mar 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.