Update to latest crypto-ld and jsigs api. #83

dmitrizagidulin · 2020-08-10T03:02:20Z

Depends on:

Enables:

Refactor to use new crypto-ld and jsigs api. zcap#50

aljones15 · 2020-12-10T10:54:57Z

it looks like this has lint issues causing the test suite to fail.

EDIT: actually it looks like tests are failing in this branch.

my local test-node result:

  verify API (presentations)
    1) verifies a valid signed presentation
    2) verifies an unsigned presentation

  tests for multiple credentials
    3) cause error when credentials are tampered
    4) should not cause error when credentials are correct
    5) cause error when credentials are tampered
    6) should not cause error when credentials are correct
    7) cause error when credentials are tampered
    8) should not cause error when credentials are correct
    9) cause error when credentials are tampered
    10) should not cause error when credentials are correct


  18 passing (2s)
  10 failing

  1) verify API (presentations)
       verifies a valid signed presentation:
     VerificationError: Verification error(s).
      at Object.verify (node_modules/jsonld-signatures/lib/jsonld-signatures.js:124:22)                              
      at _verifyPresentation (lib/vc.js:436:30)                                                                      
      at Context.<anonymous> (tests/10-verify.spec.js:319:20)                                                        
                                                                                                                     
  2) verify API (presentations)
       verifies an unsigned presentation:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:350:31)                                                        
                                                                                                                     
  3) tests for multiple credentials
       cause error when credentials are tampered:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:396:39)                                                        
                                                                                                                     
  4) tests for multiple credentials
       should not cause error when credentials are correct:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:419:33)                                                        
                                                                                                                     
  5) tests for multiple credentials
       cause error when credentials are tampered:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:396:39)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)                                            
                                                                                                                     
  6) tests for multiple credentials
       should not cause error when credentials are correct:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:419:33)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)                                            
                                                                                                                     
  7) tests for multiple credentials
       cause error when credentials are tampered:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:396:39)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)                                            
                                                                                                                     
  8) tests for multiple credentials
       should not cause error when credentials are correct:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:419:33)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)                                            
                                                                                                                     
  9) tests for multiple credentials
       cause error when credentials are tampered:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:396:39)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)                                            
                                                                                                                     
  10) tests for multiple credentials
       should not cause error when credentials are correct:

      AssertionError: expected false to be true
      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (tests/10-verify.spec.js:419:33)                                                        
      at processTicksAndRejections (internal/process/task_queues.js:93:5)

and with the test suites in

npm test

> vc-js@0.6.5-0 test /home/liminal18/Programs/nodeJS/digital_bazaar/vc-js
> bin/vc-test

evidence (cardinality) ... FAIL
evidence (objects) ... FAIL
evidence (url invalid) ... ok
evidence ... FAIL
issued (cardinality invalid) ... ok
issued (invalid) ... ok
issued (date invalid) ... ok
issued ... FAIL
issuer (cardinality invalid) ... ok
issuer (uri invalid) ... ok
issuer (object id) ... FAIL
issuer ... FAIL
minimal ... FAIL
revocation (type invalid) ... ok
revocation (url invalid) ... ok
revocation ... FAIL

======================================================================
FAIL: evidence (cardinality)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: evidence (objects)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: evidence
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: issued
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: issuer (object id)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: issuer
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: minimal
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

======================================================================
FAIL: revocation
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/../test-suites/vc-test-suite/bin/vc-driver", line 106, in runTest
    self.assertEqual(issued.returncode, 0, {
AssertionError: 1 != 0 : {'message': 'bad return code', 'stdout': b'', 'stderr': b'/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138\nconst testSuite = new jsigs.suites.Ed25519Signature2018({\n                  ^\n\nTypeError: jsigs.suites.Ed25519Signature2018 is not a constructor\n    at Object.<anonymous> (/home/liminal18/Programs/nodeJS/digital_bazaar/vc-js/bin/vc-js:138:19)\n    at Module._compile (internal/modules/cjs/loader.js:1063:30)\n    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)\n    at Module.load (internal/modules/cjs/loader.js:928:32)\n    at Function.Module._load (internal/modules/cjs/loader.js:769:14)\n    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)\n    at internal/main/run_main_module.js:17:47\n'}

----------------------------------------------------------------------
Ran 16 tests in 7.091s

FAILED (failures=8)

- Remove CI env. - Add timeouts. - Add and use Node.js 14.x.

- Add null fallbacks for unneeded libraries.

- Include .ts files. - Use globstar patterns.

- Rename uses of `vc-js` to `@digitalbazaar/vc`. - Update changelog. - Update README. - Update badges.

mrhegemon mentioned this pull request Aug 11, 2020

XR Wallet / XR Pass Roadmap ir-engine/etherealengine-archive#139

Closed

24 tasks

dmitrizagidulin force-pushed the v7.x branch from 91ad583 to 8e51a2c Compare March 8, 2021 03:23

This was referenced Mar 18, 2021

Initial implementation. digitalbazaar/ed25519-signature-2020#1

Merged

Refactor to use new crypto-ld and jsigs api. digitalbazaar/zcap#50

Merged

dmitrizagidulin and others added 9 commits March 17, 2021 22:12

Update to latest crypto-ld and jsigs api.

e8551d6

Update workflow.

9b57766

- Remove CI env. - Add timeouts. - Add and use Node.js 14.x.

Fix coverage output.

b8ff019

Update dependencies.

e91e7b8

Fix lint issues.

1008b99

Update API usage.

7de89b5

Remove testing on Node.js 10.x.

e3d86d7

Remove bin/, rename test/ dir, update copyright.

dcfff1f

Remove unused mocha.opts.

35c4e67

dmitrizagidulin force-pushed the v7.x branch from 8e51a2c to 35c4e67 Compare March 18, 2021 02:12

dmitrizagidulin added 4 commits March 17, 2021 22:34

Update to latest packages.

594a995

Set up lint, fix mocha script.

e54badb

Update karma config.

14da26b

Extract dateRegex tests to separate file.

ebcf94b

dmitrizagidulin force-pushed the v7.x branch from bb83590 to ebcf94b Compare March 18, 2021 03:49

Update to latest published packages.

f6b516c

dmitrizagidulin mentioned this pull request Mar 22, 2021

Update to test with newest jsonld-signatures version and ed25519 2020 suite #93

Closed

dmitrizagidulin and others added 8 commits March 24, 2021 21:29

Update checking for issuer and controller in validate.

df98546

Update jsonld* deps.

9d631fd

Re-enable tests.

279ec76

Fix linting errors.

b6afc94

Update to latest suite packages.

6bf79ec

Setup nyc options.

bf34996

Fix karma testing.

b0a14ac

- Add null fallbacks for unneeded libraries.

Update DID doc context URL.

1b6af76

dlongley and others added 10 commits April 21, 2021 15:24

Ensure mock DID Doc loader only loads the DID Doc/keys in it.

3cbae0b

Update dist files.

a5c7ce4

- Include .ts files. - Use globstar patterns.

Remove typescript def generation support.

e442571

No longer ship browser bundles.

34de705

Remove unused 'esm' dependency.

6f7d1ca

Rename package to @digitalbazaar/vc.

c3485ac

- Rename uses of `vc-js` to `@digitalbazaar/vc`. - Update changelog. - Update README. - Update badges.

Fix typo.

f0a70c3

Fix typo.

1861112

Fix badge links.

07eff2b

Update changelog.

f3ec4eb

davidlehn approved these changes Apr 21, 2021

View reviewed changes

davidlehn merged commit 36e22a5 into master Apr 21, 2021

dlongley deleted the v7.x branch January 8, 2023 22:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to latest crypto-ld and jsigs api. #83

Update to latest crypto-ld and jsigs api. #83

Uh oh!

dmitrizagidulin commented Aug 10, 2020 •

edited

Loading

Uh oh!

aljones15 commented Dec 10, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Update to latest crypto-ld and jsigs api. #83

Update to latest crypto-ld and jsigs api. #83

Uh oh!

Conversation

dmitrizagidulin commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aljones15 commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dmitrizagidulin commented Aug 10, 2020 •

edited

Loading

aljones15 commented Dec 10, 2020 •

edited

Loading