Refactor to use new crypto-ld and jsigs api. #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove CI env. - Use and test with Node.js 14.x. - Add timeouts.
- Use modern tools. - Ship bundled ESM version.
- Changed package name from `ocapld` to `@digitalbazaar/zcapld`.
4 tasks
dlongley
approved these changes
Mar 19, 2021
Member
dlongley
left a comment
There was a problem hiding this comment.
Rubberstamping... seems like we've covered most (all?) of the things we wanted to do with this release.
Contributor
|
@dmitrizagidulin CI is not passing (karma test failing). Is that a known issue? |
mattcollier
approved these changes
Mar 19, 2021
Contributor
mattcollier
left a comment
There was a problem hiding this comment.
LGTM once CI is passing.
- Using only webpack and targeting modern browsers.
- Update from ocapld version to prepare for new zcpald 1.0.0.
davidlehn
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Also resolves issue #33