Add source location to invalid_source_file_exceptiont#5837
Merged
tautschnig merged 2 commits intodiffblue:developfrom Jun 30, 2022
Merged
Add source location to invalid_source_file_exceptiont#5837tautschnig merged 2 commits intodiffblue:developfrom
tautschnig merged 2 commits intodiffblue:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5837 +/- ##
===========================================
- Coverage 77.80% 77.80% -0.01%
===========================================
Files 1567 1566 -1
Lines 179916 179941 +25
===========================================
+ Hits 139988 140007 +19
- Misses 39928 39934 +6
Continue to review full report at Codecov.
|
3 tasks
4 tasks
chrisr-diffblue
approved these changes
Jan 23, 2022
Contributor
chrisr-diffblue
left a comment
There was a problem hiding this comment.
That looks great to me, and is what we should have done when we first added the structured exceptions. Some nice code cleanups/refactoring along the way too.
4 tasks
6c368cc to
8e72373
Compare
4 tasks
8e72373 to
0a6a600
Compare
6d2a0f0 to
8f50ea8
Compare
tautschnig
added a commit
that referenced
this pull request
Feb 28, 2022
De-duplicate initialize_goto_model's code [blocks: #5837]
8f50ea8 to
00270a6
Compare
00270a6 to
e482a61
Compare
chris-ryder
approved these changes
Feb 28, 2022
chris-ryder
left a comment
There was a problem hiding this comment.
Previously reviewed and approved with my Diffblue account, re-approving with my non-Diffblue account to keep the CODEOWNER review.
martin-cs
approved these changes
Mar 1, 2022
Collaborator
martin-cs
left a comment
There was a problem hiding this comment.
Yes. I don't think this breaks any scripting.
e482a61 to
8bd17d9
Compare
None of our existing tests covers the failure paths of type checking saturating arithmetic and character literal conversion, respectively.
This enables proper use in the C front-end in a way that is compatible with the compiler-specific message handlers in goto-cc: those message handlers generate source-location output that mimics that of the compiler being emulated. As future work it is thus possible to remove all "throw 0" instances from the C front-end.
8bd17d9 to
0470384
Compare
peterschrammel
approved these changes
Jun 30, 2022
| error() << e << eom; | ||
| } | ||
|
|
||
| catch(const invalid_source_file_exceptiont &e) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables proper use in the C front-end in a way that is compatible
with the compiler-specific message handlers in goto-cc: those message
handlers generate source-location output that mimics that of the
compiler being emulated.
As future work it is thus possible to remove all "throw 0" instances
from the C front-end.