Make validation mode parameter explicit in DATA_CHECK macros [blocks #3287]#3480
Merged
tautschnig merged 1 commit intodiffblue:developfrom Dec 1, 2018
Conversation
ddfa911 to
be9f1a9
Compare
6 tasks
chrisr-diffblue
approved these changes
Nov 29, 2018
be9f1a9 to
76f0ec7
Compare
allredj
reviewed
Nov 29, 2018
Contributor
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 76f0ec7).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/93038258
NlightNFotis
approved these changes
Nov 30, 2018
Contributor
NlightNFotis
left a comment
There was a problem hiding this comment.
LGTM. This is well done, prefer the explicit passing of it around to the assumption that a vm variable should be in scope.
tautschnig
added a commit
that referenced
this pull request
Dec 1, 2018
Well-formedness checking of SSA equation [depends on #3480]
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @tautschnig in a comment to an earlier PR, this makes the validation mode an explicit parameter of the
DATA_CHECK()macros.