libtbx_refresh.py: find dist-info in the install directory instead of src#2906
Conversation
|
Ah, I looked at the failures this evening but forgot about that nuance |
|
right, me too :) any thoughts on 6172520? Is it sufficient to put the installed location in the python path, or does src also need to be there explicitly? (we'll see if the tests pass...) |
|
|
|
Yes, I have a file inside |
| if rel_path not in env.pythonpath: | ||
| env.pythonpath.insert(0, rel_path) | ||
| # As of PEP 660, the package metadata (dist-info) goes in the install dir, | ||
| # not the source dir. Add this location to the python path too. |
There was a problem hiding this comment.
I think with that latest change this is now not "too"
| # not the source dir. Add this location to the python path too. | |
| # not the source dir. Add this location to the python path. |
|
Otherwise, I think this looks good to merge dxtbx, then revert the branch changing here for final testing? |
… src (#807) See dials/dials#2902 and dials/dials#2906 Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Legacy-editable mode was removed in pypa/setuptools#4953, this env variable no longer does anything. We accommodate the new behavior in cctbx/dxtbx#807 and dials/dials#2906.
|
Thank you very much for your work on this! |
See dials/dials#2906. Also, tidy up typing slightly here.
See dials/dials#2906. Also, tidy up typing slightly here.
… src (cctbx#807) See dials/dials#2902 and dials/dials#2906 Co-authored-by: Nicholas Devenish <ndevenish@gmail.com>
Fixes #2902