Add test for changing type of field inside Optional#1332
Merged
Gabriella439 merged 2 commits intomasterfrom Apr 6, 2023
Merged
Add test for changing type of field inside Optional#1332Gabriella439 merged 2 commits intomasterfrom
Optional#1332Gabriella439 merged 2 commits intomasterfrom
Conversation
The Haskell implementation of Dhall had a bug where it permitted
this update, leading to an invalid inferred type:
```dhall
⊢ (None { x : Natural }) with ?.x = True
None { x : Natural }
```
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Apr 5, 2023
See: dhall-lang/dhall-lang#1332 The standard already required this, but the Haskell implementation was not correctly conforming to the standard. Fixing this not only simplifies the Haskell code but also makes the code more greatly resemble the corresponding standard judgement.
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Apr 16, 2023
See: dhall-lang/dhall-lang#1332 The standard already required this, but the Haskell implementation was not correctly conforming to the standard. Fixing this not only simplifies the Haskell code but also makes the code more greatly resemble the corresponding standard judgement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Haskell implementation of Dhall had a bug where it permitted this update, leading to an invalid inferred type: