Add Prelude/Map/unpackOptionals#1056
Conversation
fe2535c to
2c73136
Compare
german1608
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
I noticed in #1053 all the relative imports are now using
.dhallextensions; should I edit my PR to importunpackOptionals.dhall?
Yes, please. In my review, I left you other places where you should use the .dhall import as well.
Also, is there a script to recursively re-freeze files when you change the prelude?
Although I'm not 100% sure, the ./scripts/lint-prelude.sh seems like the tool you're looking for.
|
Thanks. I applied your changes; let me know if they should be squashed into a single commit.
|
german1608
left a comment
There was a problem hiding this comment.
LGTM! Thanks @JackKelly-Bellroy!
Co-authored-by: German Robayo <germanrobayo33@gmail.com>
Co-authored-by: German Robayo <germanrobayo33@gmail.com>
Non-.dhall-suffixed files are for backwards compatibility only.
Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
a4e35f7 to
d94cc43
Compare
Gabriella439
left a comment
There was a problem hiding this comment.
Looks great! We can merge after the 7-day waiting period is over
|
Excellent. When can we ship this? |
|
@JackKelly-Bellroy: There will be another release coming up soon. By default we release on a roughly monthly cadence and the last release was about a month ago |
|
Thanks for the heads-up @Gabriel439 . Looking forward to it. |
|
@JackKelly-Bellroy: The pull request to cut the next release is up here: #1059 |
I needed this when implementing regadas/github-actions-dhall#20 and it feels generic enough that it would be useful in the prelude.
I noticed in #1053 all the relative imports are now using
.dhallextensions; should I edit my PR to importunpackOptionals.dhall?Also, is there a script to recursively re-freeze files when you change the prelude?