New action: actions/haskell-setup#20
Merged
regadas merged 3 commits intoregadas:masterfrom Aug 28, 2020
JackKelly-Bellroy:actions/haskell-setup
Merged
New action: actions/haskell-setup#20regadas merged 3 commits intoregadas:masterfrom JackKelly-Bellroy:actions/haskell-setup
regadas merged 3 commits intoregadas:masterfrom
JackKelly-Bellroy:actions/haskell-setup
Conversation
This was referenced Aug 17, 2020
Owner
I agree can you swap it around and rebase. If you could make a new PR for the |
regadas
reviewed
Aug 24, 2020
Contributor
Author
|
Rebased atop #21 which fixes the There are a couple of things I'd like to talk about before merge:
|
regadas
approved these changes
Aug 28, 2020
Contributor
Author
|
Thanks. Also, I assume that since you've merged this PR, we're happy to have argument schemata, if I need to use those again on larger actions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new action
actions/haskell-setup, mapping to the githubactions/setup-haskell. The name is swapped around for consistency withactions/java-setupin this repo, but it might be a bad idea to establish a pattern where thegithub-actions-dhallnames differ from the actual names of actions. I'm willing to rename this tosetup-haskelland also dojava-setup->setup-javaif you think that's better.I've also needed to import more things from prelude here. Let me know if you're happy with how I'm doing this, or if you'd rather some other way of getting the prelude (such as
/deps/Prelude.dhallcontaining a single frozen import or something).This PR is rebased atop #19, to hopefully avoid merge conflicts on the dhall SHA256s. Merge that first and the diff here won't have the cache noise. If you merge something else in-between, let me know and I will re-freeze and rebase this PR.