Skip to content

chore: Migrate from pep517 to python-build#33

Merged
dguest merged 2 commits into
dguest:masterfrom
matthewfeickert:chore/migrate-from-pep517-to-build
Sep 22, 2020
Merged

chore: Migrate from pep517 to python-build#33
dguest merged 2 commits into
dguest:masterfrom
matthewfeickert:chore/migrate-from-pep517-to-build

Conversation

@matthewfeickert

@matthewfeickert matthewfeickert commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

Switch from using the now deprecated pep517 to build sdist and wheels to the new python-build library. c.f. scikit-hep/pyhf#1066 for more context.

(I forgot to migrate this over into PR #29 once we learned about this for pyhf).

Suggested squash and merge commit message

* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging
   - c.f. https://github.com/pypa/pep517/pull/83
* Remove check stage as done implicitly with python-build

@matthewfeickert matthewfeickert marked this pull request as ready for review September 22, 2020 08:14
@matthewfeickert

matthewfeickert commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator Author

@dguest This is ready for review (sorry I forgot to update PR #29 with this when I learned about the change last week).

@dguest dguest merged commit bf95550 into dguest:master Sep 22, 2020
@matthewfeickert matthewfeickert deleted the chore/migrate-from-pep517-to-build branch September 22, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewfeickert @dguest