Skip to content

chore: Migrate from pep517 to python-build#1066

Merged
kratsg merged 8 commits into
masterfrom
chore/migrate-from-pep517-to-build
Sep 15, 2020
Merged

chore: Migrate from pep517 to python-build#1066
kratsg merged 8 commits into
masterfrom
chore/migrate-from-pep517-to-build

Conversation

@matthewfeickert

@matthewfeickert matthewfeickert commented Sep 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Resolves #1065

Switch from using the now deprecated pep517 to build sdist and wheels to the new python-build library.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging
   - c.f. https://github.com/pypa/pep517/pull/83
* Remove check stage as done implicitly with python-build
   - c.f. https://github.com/FFY00/python-build/issues/105

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions packaging setup.py, setup.cfg, pyproject.toml, and friends labels Sep 14, 2020
@matthewfeickert matthewfeickert self-assigned this Sep 14, 2020
matthewfeickert
matthewfeickert commented Sep 14, 2020
View reviewed changes
Comment thread .github/workflows/publish-package.yml Outdated
Comment thread .github/workflows/publish-package.yml Outdated
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Sep 14, 2020
@codecov

codecov Bot commented Sep 14, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1066 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1066   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          59       59           
  Lines        3451     3451           
  Branches      499      499           
=======================================
  Hits         3340     3340           
  Misses         68       68           
  Partials       43       43
Flag Coverage Δ
#unittests 96.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab1d8d...3001794. Read the comment docs.

@matthewfeickert matthewfeickert changed the title chore: Migrate from pep517 to build chore: Migrate from pep517 to python-build Sep 15, 2020
@matthewfeickert matthewfeickert marked this pull request as ready for review September 15, 2020 00:41
@matthewfeickert

matthewfeickert commented Sep 15, 2020

Copy link
Copy Markdown
Member Author

@kratsg @lukasheinrich We're going to be early adopters here, but we seem to be safe from the known bugs of python-build and it seems that pep517 will be getting deprecated, so perhaps worth moving now.

@kratsg kratsg merged commit 8a6ee36 into master Sep 15, 2020
@kratsg kratsg deleted the chore/migrate-from-pep517-to-build branch September 15, 2020 10:24
@matthewfeickert matthewfeickert mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kratsg kratsg kratsg approved these changes

@lukasheinrich lukasheinrich lukasheinrich approved these changes

Assignees

@matthewfeickert matthewfeickert

Labels

chore Other changes that don't modify src or test files CI CI systems, GitHub Actions packaging setup.py, setup.cfg, pyproject.toml, and friends

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate from pep517 to using build in tests and workflows

3 participants

@matthewfeickert @kratsg @lukasheinrich