Fix integer overflow error when building for 386#1541
Fix integer overflow error when building for 386#1541jarifibrahim merged 6 commits intodgraph-io:masterfrom gammazero:build386
Conversation
The untyped const causes conversion to int, for which the value is too large. Use a typed const instead that is large enough to store value.
|
|
jarifibrahim
left a comment
There was a problem hiding this comment.
Thanks @gammazero 🎉 . This might fix the build but we've seen other cannot allocate memory errors on 386. We can handle those in a separate PR.
@NamanJain8 review please.
|
Thanks for helping with the review @damz :) |
NamanJain8
left a comment
There was a problem hiding this comment.
This looks good. Thanks, @gammazero.
|
Not directly related to the PR itself, @jarifibrahim I was wondering about the use of |
Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com>
|
The DeepSource and the travis-ci build failures are not related to this PR, and can/should be fixed in a separate PR. |
|
Thanks for fixing this @gammazero |
The untyped const causes conversion to int, for which the value is too large. Use a typed const instead that is large enough to store value.
|
Hi, will this fix be backported to v2.2007? |
I have created #1558 to fix this issue in v2.2007. |
The untyped const causes conversion to int, for which the value is too large. Use a typed const instead that is large enough to store value. Similar to #1541, but for v2.2007 branch.
The untyped const causes conversion to int, for which the value is too large.
Use a typed const instead that is large enough to store value.
This change is