Fix build on Plan 9 by fhs · Pull Request #1451 · dgraph-io/badger

fhs · 2020-08-04T22:10:00Z

Plan 9 doesn't have mmap, so we just return an error.

File locking is implemented using the exclusive mode bit.
From http://man.cat-v.org/plan_9/5/open:

If the file is marked for exclusive use (see stat(5)), only
one client can have the file open at any time. That is,
after such a file has been opened, further opens will fail
until fid has been clunked.

Initial attempt at implementing directory locking using this method was
not successful because badger seems to be opening the directory multiple
times (at least while running the test suite). As a workaround, we lock
the pid lock file instead of the directory itself, same as the windows
implementation.

This change is

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation.

CLAassistant · 2020-08-04T22:10:05Z

All committers have signed the CLA.

jarifibrahim

This is awesome work @fhs 🎉. Thank you for fixing this. I have some comments.

I'm wondering how do we test this PR. Can you also add a GOOS=plan9 build to travis CI?

dir_plan9.go

Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com>

dir_plan9.go

fhs · 2020-08-05T14:23:34Z

I've added GOOS=plan9 build to travis CI.

dir_plan9.go

y/file_dsync.go

Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com>

jarifibrahim

LGTM. Thanks for the PR @fhs 🎉 . I made one small line length change on this PR.

I'll merge this PR once CI finishes.

fhs · 2020-09-05T22:55:49Z

When can I expect this to be included in a release? I need this in a v1.6.x release to get ipfs working, but I can also wait for v1.7.0. IPFS tracking issue for Plan 9 support: ipfs/kubo#7575

jarifibrahim · 2020-09-07T17:51:39Z

We will be doing a badger 1.x release this week. This patch would be in that release.

@NamanJain8 This needs to go in 1.x release.

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb)

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com>

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>

francislavoie · 2021-08-23T05:22:21Z

Looks like this was never backported to badger v2. Could we make that happen?

Building against v2.2007.3 which is the version Caddy is currently depending on (via smallstep) yields these errors:

# github.com/dgraph-io/badger/v2/y
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\file_dsync.go:24:21: undefined: unix.O_DSYNC
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:30:11: undefined: unix.PROT_READ
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:32:12: undefined: unix.PROT_WRITE
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:34:9: undefined: unix.Mmap
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:34:54: undefined: unix.MAP_SHARED
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:39:9: undefined: unix.Munmap
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:46:11: undefined: unix.MADV_NORMAL
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:48:11: undefined: unix.MADV_RANDOM
..\..\..\..\go\pkg\mod\github.com\dgraph-io\badger\v2@v2.2007.3\y\mmap_unix.go:50:9: undefined: unix.Madvise

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com>

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com> Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com>

Plan 9 doesn't have mmap, so we just return an error. File locking is implemented using the exclusive mode bit. From http://man.cat-v.org/plan_9/5/open: If the file is marked for exclusive use (see stat(5)), only one client can have the file open at any time. That is, after such a file has been opened, further opens will fail until fid has been clunked. Initial attempt at implementing directory locking using this method was not successful because badger seems to be opening the directory multiple times (at least while running the test suite). As a workaround, we lock the pid lock file instead of the directory itself, same as the windows implementation. Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io> (cherry picked from commit 07fa3eb) Co-authored-by: Fazlul Shahriar <fshahriar@gmail.com>

fhs requested review from ashish-goswami, jarifibrahim and manishrjain as code owners August 4, 2020 22:10

fhs mentioned this pull request Aug 5, 2020

Add support for Plan 9 ipfs/kubo#7575

Closed

5 tasks

jarifibrahim reviewed Aug 5, 2020

View reviewed changes

dir_plan9.go Show resolved Hide resolved

dir_plan9.go Outdated Show resolved Hide resolved

dir_plan9.go Outdated Show resolved Hide resolved

dir_plan9.go Outdated Show resolved Hide resolved

Apply suggestions from code review

6e40722

Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com>

jarifibrahim reviewed Aug 5, 2020

View reviewed changes

dir_plan9.go Outdated Show resolved Hide resolved

fhs added 4 commits August 5, 2020 09:59

Remove readOnly field from Plan 9 directoryLockGuard

fd49e59

Remove double writes to pid file on Plan 9

1b0eac4

Add comment explaining directory locking on Plan 9

1df3849

Add Plan 9 cross-compilation to Travis CI

98aee4c

NamanJain8 reviewed Aug 10, 2020

View reviewed changes

dir_plan9.go Show resolved Hide resolved

NamanJain8 reviewed Aug 10, 2020

View reviewed changes

y/file_dsync.go Show resolved Hide resolved

fhs and others added 3 commits August 10, 2020 10:37

Update dir_plan9.go

4d14de4

Co-authored-by: Ibrahim Jarif <jarifibrahim@gmail.com>

Add plan9 build tag to file_nodsync.go

a8d1123

Fix line length in dir_plan9.go file

583928b

jarifibrahim approved these changes Aug 19, 2020

View reviewed changes

jarifibrahim merged commit 07fa3eb into dgraph-io:master Aug 20, 2020

fhs deleted the plan9-pr branch September 5, 2020 22:41

francislavoie mentioned this pull request Aug 23, 2021

Caddy Build Fails for Solaris/Illumos and Plan9 caddyserver/caddy#3615

Closed

francislavoie mentioned this pull request Aug 23, 2021

Backport "Fix build on Plan 9" to Badger v2 #1738

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build on Plan 9#1451

Fix build on Plan 9#1451
jarifibrahim merged 9 commits intodgraph-io:masterfrom
fhs:plan9-pr

fhs commented Aug 4, 2020 •

edited by manishrjain

Loading

Uh oh!

CLAassistant commented Aug 4, 2020 •

edited

Loading

Uh oh!

jarifibrahim left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhs commented Aug 5, 2020

Uh oh!

Uh oh!

Uh oh!

jarifibrahim left a comment

Uh oh!

fhs commented Sep 5, 2020

Uh oh!

jarifibrahim commented Sep 7, 2020

Uh oh!

francislavoie commented Aug 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Conversation

fhs commented Aug 4, 2020 • edited by manishrjain Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jarifibrahim left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fhs commented Aug 5, 2020

Uh oh!

Uh oh!

Uh oh!

jarifibrahim left a comment

Choose a reason for hiding this comment

Uh oh!

fhs commented Sep 5, 2020

Uh oh!

jarifibrahim commented Sep 7, 2020

Uh oh!

francislavoie commented Aug 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

fhs commented Aug 4, 2020 •

edited by manishrjain

Loading

CLAassistant commented Aug 4, 2020 •

edited

Loading