[CMS PR 35874] Add stuff from system templates to deleted files and folders and files for preview images to the move to media folder#6
Conversation
There are 2 possible solutions here:
I find using PHP for this task is overkill thus I went with the move of the files. Just a reminder that all these files moving make sense if you consider the reason behind them: keep the templates folder inaccessible from the browser, the entry points for any well-tuned Joomla site should be:
|
@dgrammatiko I still don't get why it needs to move the preview images. Can they really have been modified by a user for a core template and do we want to keep these modifications? |
Update SQL Scripts for Postgresql and MySQL and Code Cleanup
Pull Request for Issue # .
Summary of Changes
Folder::existsin the if condition (was copied from elsewhere).@dgrammatiko Question: Does it really need to move the preview images? It only makes sense if they could have been modified by the user. If not, they would be in the update package for the media folder and deleted with the regular file delete at the old place, i.e. changes 2. and 3. should be reverted.