[CMS PR 35874] Move custom files in core templates to media folder on update#5
Merged
dgrammatiko merged 2 commits intodgrammatiko:4.1-dev-child-templatesfrom Oct 22, 2021
Conversation
Owner
|
Yay, thanks!!! |
dgrammatiko
pushed a commit
that referenced
this pull request
Feb 21, 2023
Update dev to the latest version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#35874 .
Summary of Changes
This is how I would do it with the custom files.
I'd move them and not copy because this is open to any later possible change for the "Folder::delete" to delete folders on update only if they are not empty, like it was discussed a while ago e.g. with Brian T. in some other issue or PR in the CMS repo.
Feel free to change that if you thing copying is the safer way, as those files and folder will be deleted anyway at the end and for the intermediate time it might be safer to keep the old one e.g. due to cache issues or whatever.
I've also included a "js" folder for the Atum template even if the core doesn't have that, but a user might have created that for some custom JS.
Feel free to remove that if you don't like it.
And of course you can change other things too on my proposal, as at the end it is your PR where it goes in.
I haven't tested it yet but it should work 😄