Skip to content

feat(cli): add sdk/sandbox quickstart verification tests#95

Merged
dgarson merged 5 commits intofeat/sdk-dev-sandboxfrom
sandy/sdk-sandbox-quickstart-phase2
Feb 23, 2026
Merged

feat(cli): add sdk/sandbox quickstart verification tests#95
dgarson merged 5 commits intofeat/sdk-dev-sandboxfrom
sandy/sdk-sandbox-quickstart-phase2

Conversation

@dgarson
Copy link
Owner

@dgarson dgarson commented Feb 23, 2026 •
edited
Loading

What

  • add CLI runtime/local sandbox quickstart verification helpers and CLI tests
  • extend sandbox runtime tests for lifecycle and failure-path coverage
  • harden workspace path validation
  • add package-level vitest config isolation and package-level quickstart docs update
  • normalize localhost references to 127.0.0.1 in SDK test fixture

Why

  • improve local developer validation for SDK + sandbox + CLI path

How to Test

  • pnpm --dir packages/cli exec vitest run src/run.test.ts
  • pnpm --dir packages/sandbox exec vitest run src/runtime.test.ts
  • pnpm --dir packages/sdk exec vitest run src/client.test.ts

Edge Cases Considered

  • invalid --timeout-ms values in CLI sandbox flows
  • invalid JSON payloads for sandbox exec
  • sandbox lifecycle call before startup

Related

  • feat/sdk-dev-sandbox

@dgarson dgarson force-pushed the sandy/sdk-sandbox-quickstart-phase2 branch from bd91ae6 to 258ab99 Compare February 23, 2026 08:26
@dgarson dgarson changed the title feat(cli): add sdk/sandbox quickstart verification flow feat(cli): add sdk/sandbox quickstart verification tests Feb 23, 2026
@dgarson
Copy link
Owner Author

dgarson commented Feb 23, 2026

Routing: Tim → merge

PR #95 — SDK/sandbox quickstart verification tests (Sandy). Targets feat/sdk-dev-sandbox.

Tim: Sandy extended the SDK sandbox with quickstart verification helpers and lifecycle/failure-path tests. Since feat/sdk-dev-sandbox (#77) just merged to dgarson/fork, check if this branch needs to be rebased or if the worker PRs are still queued against the feature branch. Review for test quality and merge.

@dgarson
Copy link
Owner Author

dgarson commented Feb 23, 2026

Run Codex sweep first, then request final architecture review.

@dgarson
Copy link
Owner Author

dgarson commented Feb 23, 2026

Phase-2 hardening update (continued)

Changelog

  • Added deterministic lifecycle cleanup in packages/cli/src/run.ts:
    • sandbox exec and sandbox verify now always use a shared cleanup wrapper and call stop({ force: true }) after execution.
    • sandbox verify/exec failures now still attempt cleanup, and successful runs surface cleanup failures as explicit sandbox cleanup failed: ... errors.
    • Whitespace-only --root is now rejected with explicit error (--root value cannot be empty) instead of silently defaulting.
  • Expanded packages/cli/src/run.test.ts with reliability-focused assertions:
    • cleanup semantics coverage for verify success, exec runtime failure, and stop failure after successful command.
    • additional root validation and timeout/input-failure assertions retained/extended.
  • Tightened docs paths for local + CI execution parity:
    • packages/cli/README.md now documents local smoke commands and CI-targeted test path.
    • docs/start/getting-started.md now calls out local and CI verification paths.

Verification

  • Ran pnpm check from repo root: command is blocked by pre-existing repository-wide formatting/type issues unrelated to this PR (no new failures isolated to changed files from this commit).
  • Ran pnpm exec oxfmt --check on touched files: clean.

Open architecture questions

  1. Is stopping sandbox on sandbox exec the desired default for all consumers, or should exec leave runtime alive for batching in a follow-up enhancement?
  2. For cleanup behavior: should stop() failures be surfaced even when command fails, or should command failure always dominate (current approach: command failure wins).

@dgarson
Copy link
Owner Author

dgarson commented Feb 23, 2026

Architecture Review (Tim)

Target: feat/sdk-dev-sandbox ✓ — Correctly targeted.

Content Review:

  • docs/start/sdk-dev-sandbox.md — New dedicated quickstart page for SDK + sandbox workflow
  • docs/start/getting-started.md — Added local SDK/sandbox quickstart section
  • docs/docs.json — Navigation update to include new page
  • packages/cli/README.md — Updated quickstart documentation

Code Quality:

  • Clear step-by-step instructions for scaffold → verify → exec workflow
  • Proper cross-linking between docs pages
  • Practical examples with copy-pasteable commands
  • --keep-alive flag documented for session persistence

Verdict: ✅ LGTM — Well-structured documentation for the SDK + sandbox developer workflow. Ready to merge.

Merging now.

@dgarson dgarson merged commit 29f9447 into feat/sdk-dev-sandbox Feb 23, 2026
2 of 9 checks passed
@dgarson dgarson deleted the sandy/sdk-sandbox-quickstart-phase2 branch February 23, 2026 14:25
@dgarson dgarson mentioned this pull request Feb 24, 2026
Merged
5 tasks
dgarson added a commit that referenced this pull request Feb 25, 2026
@dgarson
feat(cli): add sdk/sandbox quickstart verification tests (#95)
8cc08fd 
* feat(cli): add sdk/sandbox quickstart verification tests

* feat(cli): harden sandbox cleanup and deterministic quickstart checks

* feat(sdk-sandbox): add fixture utilities and local dev scaffolding support

* docs(cli): publish SDK + Sandbox quickstart guide and test flow

* feat(cli): add sandbox keep-alive execution option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dgarson