Conversation
1fe1ace to
1dacacb
Compare
|
@dg I'm unable to configure the tests, help needed. I'm able to repliate the error via github actions in my fork, but appveyor uses different DB config provider. |
|
Also, I tried the |
1dacacb to
357041e
Compare
Fixes error in PHP 8 when calling MySqliDriver::getResource with the resource being closed prior to the call
357041e to
8517eec
Compare
|
Thanks |
|
@dg The tests need to be updated. It was marked |
|
I used a test like this: 7d82ce2#diff-1a3150d75da0d135bea2c37b25a578bf7aa75308db33a297abd067e27ffe558f |
|
If you're okay with the test, fine. Still, there's the dangling code that should be removed: 8c2e425#diff-2e359a78bf001eae825dda38b8e9565c483c4a62089440534f2129aea7115538R26 Should I open a new PR? |
|
Yeah, I put the code away. |
|
Oh, sorry, I did not notice. |
|
Hello. |
|
So use dev-4.2.x in the meantime. |
|
That works fine for development, not for production. |
closes #409