SqlsrvDriver compatibility fix for SQL Server 2012 and 2014#206
Merged
Conversation
added 3 commits
January 26, 2016 13:11
… 11+ SqlsrvReflector: changed constrains metadata loading from INFORMATION_SCHEMA to sys schema to get complete list of all constraints, not PK only
Owner
|
Great, thank you! |
Contributor
Author
|
What's gonna be next? Is there anything you need from me or what can I help you with? |
Owner
|
Is it ready to merge? Probably the last two commits should be merged together. |
Contributor
Author
|
Almost - what about the failing test? Should I skip this Assert? What about Sql server 2008? It is still bugged... |
Contributor
Author
|
I've cleaned code to be similar to your code style and I have also allowed sqlsrv 2014 on AppVeyor as well and it seems it's working there. |
Owner
|
Thank you very much, it is great! |
dg
added a commit
that referenced
this pull request
Jan 28, 2016
SqlsrvDriver compatibility fix for SQL Server 2012 and 2014
Contributor
Author
|
You are welcome. When can I expect a new tag & release? Is is a question of day(s) or rather week(s)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed limit & offset
fixed index and table metadata loading
fixed tests for sqlsrv
changed AppVeyor SQL Server environment from 2008 to 2012 (version 2008 remains incompatible)
NOTE: meta.phpt(20) will fail, because on AppVeyor database, there is schema dbo with 9 tables instead of 3: