Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring and Cleanup#647
Merged
jalal246 merged 5 commits intodev/wip_5_10from May 15, 2023
Conversation
jalal246
added a commit
that referenced
this pull request
May 15, 2023
… Improved Element Position Detection (#645) * Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring, and Cleanup (#647). * Migrate related box model in `Threshold` to the Box Model (#646). * Utilize `computedStyle` and prevent duplicated value parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements and fixes as follows:
Utilize CSS getters and setters:
Fix resizing event handler:
Enhanced element position detection:
Remove the optional object for setting the inner scroll threshold:
Refactor and remove unnecessary methods in the Threshold class: