Skip to content

Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring and Cleanup#647

Merged
jalal246 merged 5 commits intodev/wip_5_10from
dev/wip_5_12
May 15, 2023
Merged

Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring and Cleanup#647
jalal246 merged 5 commits intodev/wip_5_10from
dev/wip_5_12

Conversation

@jalal246
Copy link
Member

@jalal246 jalal246 commented May 11, 2023

This PR introduces several improvements and fixes as follows:

  1. Utilize CSS getters and setters:

    • This update enhances the library's usage of CSS getters and setters for improved performance and compatibility.
  2. Fix resizing event handler:

    • Addressed a bug in the resizing event handler that failed to trigger the expected chain of updaters related to the event. This fix ensures that the chain of updaters is correctly executed.
  3. Enhanced element position detection:

    • Introduced a unified logic to detect an element's position relative to the viewport. This enhancement provides a more consistent and accurate position calculation.
  4. Remove the optional object for setting the inner scroll threshold:

    • Eliminated the need for an optional object parameter when setting the inner scroll threshold. This simplifies the API and improves code readability.
  5. Refactor and remove unnecessary methods in the Threshold class:

    • Streamlined the Threshold class by removing unnecessary methods and increasing reliance on the Box model. This refactoring improves code efficiency and maintainability.

@github-actions github-actions bot added the Utils label May 12, 2023
@jalal246 jalal246 changed the title init Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring and Cleanup May 15, 2023
@jalal246 jalal246 merged commit 11e30ca into dev/wip_5_10 May 15, 2023
@jalal246 jalal246 deleted the dev/wip_5_12 branch May 15, 2023 16:52
jalal246 added a commit that referenced this pull request May 15, 2023
… Improved Element Position Detection (#645)

* Implement CSS Getters and Setters, Resize Event Handler Fix, Enhanced Element Position Detection, Refactoring, and Cleanup (#647).

* Migrate related box model in `Threshold` to the Box Model (#646).

* Utilize `computedStyle` and prevent duplicated value parsing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant