This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Nix: Track haskell-upgrades#37
Merged
marcin-dziadus merged 1 commit intodfinity:masterfrom Sep 24, 2021
Merged
Conversation
in dfinity#30 we tracked a PR against nixpkgs, which isn't very stable (e.g. if it gets force-pushed to, it may break this repository). The changes we are trying to include are still not in nixpkgs master, but they are closer already, on the `haskell-upgrades` branch. So track that, until it is merged into `master` (via NixOS/nixpkgs#138596)
|
Not sure if you've seen it, but there is a convenient site to tell when a PR you care about gets into master or the relevant channels: https://nixpk.gs/pr-tracker.html?pr=138596 |
Contributor
Author
|
(This is a draft until https://github.com/nomeata/ic-hs/runs/3698287099?check_suite_focus=true is green. Recompiling all the musl/static stuff always takes a while) |
marcin-dziadus
approved these changes
Sep 24, 2021
Contributor
It's finally green. |
nomeata
added a commit
to nomeata/ic-hs
that referenced
this pull request
Sep 30, 2021
with NixOS/nixpkgs#138596 merged into `master` we can track that again, which is cleaner. This is a follow-up to dfinity#37
marcin-dziadus
pushed a commit
that referenced
this pull request
Sep 30, 2021
with NixOS/nixpkgs#138596 merged into `master` we can track that again, which is cleaner. This is a follow-up to #37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #30 we tracked a PR against nixpkgs, which isn't very stable (e.g. if
it gets force-pushed to, it may break this repository). The changes we
are trying to include are still not in nixpkgs master, but they are
closer already, on the
haskell-upgradesbranch. So track that, untilit is merged into
master(via NixOS/nixpkgs#138596)