This repository was archived by the owner on Jan 19, 2026. It is now read-only.
Show error to tell developer they added a styleguide block for an undefined section#18
Merged
dewski merged 2 commits intodewski:masterfrom Feb 14, 2013
jankeesvw:throw-error-when-style-is-missing
Merged
Show error to tell developer they added a styleguide block for an undefined section#18dewski merged 2 commits intodewski:masterfrom jankeesvw:throw-error-when-style-is-missing
dewski merged 2 commits intodewski:masterfrom
jankeesvw:throw-error-when-style-is-missing
Conversation
Owner
There was a problem hiding this comment.
I don't mind having inline unless conditionals on shorter statements, but let's just wrap this with an if:
if !@section.raw
raise "KSS styleguide section is nil, is section: '#{section}' defined in your css?"
end
Owner
|
I know I've ran into this myself, so good idea! Just the one tiny comment and I'll |
dewski
pushed a commit
that referenced
this pull request
Feb 14, 2013
Show error to tell developer they added a styleguide block for an undefined section
Author
|
hey @dewski I fixed the code 👍 |
Author
|
Thanks, that's fast ⏩ ⏩ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds an error when a developer adds a section that isn't defined in css yet. I've had this question several times in my team.