Added WIP comments to shuffle.py#2
Open
p-yang wants to merge 10 commits intodevin-petersohn:df_groupbyfrom
Open
Added WIP comments to shuffle.py#2p-yang wants to merge 10 commits intodevin-petersohn:df_groupbyfrom
p-yang wants to merge 10 commits intodevin-petersohn:df_groupbyfrom
Conversation
598d652 to
e81977d
Compare
devin-petersohn
added a commit
that referenced
this pull request
Mar 16, 2018
e81977d to
f98a3dc
Compare
devin-petersohn
added a commit
that referenced
this pull request
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes while I was reading through shuffle.py.
This should be a placeholder for now, unless you think the comments are sufficient. I might add more as we work on the rebuild functions.