Skip to content

Conversation

@tupaschoal
Copy link
Contributor

original:
apachekafka_original
original-wordmark:
apachekafka_original-wordmark

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 5, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work.
I see this icon as brown-black, but I see the icon completely black on their website. Do you think you could change it to black? Thanks.

Co-authored-by: David Leal <halfpacho@gmail.com>
@tupaschoal
Copy link
Contributor Author

I see this icon as brown-black, but I see the icon completely black on their website. Do you think you could change it to black?

It looks black, but it's brownish, take a look at the logo I got directly from https://kafka.apache.org/ by doing web code inspection: https://kafka.apache.org/logos/kafka_logo--simple.png

@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 6, 2021
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 6, 2021
@Panquesito7 Panquesito7 changed the title new icon: Apache Kafka (original, original-wordmark) new icon: apachekafka (original, original-wordmark) Jul 6, 2021
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Panquesito7 Panquesito7 added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @tupaschoal! Thanks for your contribution! 👍 🎉

@Panquesito7 Panquesito7 merged commit 942c766 into devicons:develop Jul 6, 2021
@tupaschoal tupaschoal deleted the add-apache-kafka branch July 6, 2021 23:31
@Panquesito7 Panquesito7 linked an issue Jul 6, 2021 that may be closed by this pull request
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* Close devicons#598: Add Apache Kafka

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon request: Apache Kafka

2 participants