Skip to content

Conversation

@Panquesito7
Copy link
Member

I added a new icon for The Algorithms organization.
Thanks to @maltejur for improving and making the icons as per the repo standards. 🙂

This is how they look:

Original Plain Original wordmark Plain wordmark

@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Feb 25, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Panquesito7 Panquesito7 added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Feb 25, 2021
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below:

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Copy link
Member

@Thomas-Boi Thomas-Boi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to be merged for me.

Offtopic: Should we figure out who can merge which changes? Right now, amacado has to handle everything but I think I can merge icon PR as well. What do you guys think?

@Panquesito7
Copy link
Member Author

Right now, @amacado has to handle everything but I think I can merge icon PR as well. What do you guys think?

Offtopic: Well, you have Owner access in the whole organization, so you can merge changes if they look good. I think it's OK that you can merge icon PRs. If @amacado or someone else finds an issue, they have to make another PR to fix the issue in the icon PR. TL;DR: Sounds good to me. I have fewer privileges than you and I can still merge PRs. Hope I get to understand. 🙂

@Thomas-Boi Thomas-Boi merged commit 0b6158b into devicons:develop Feb 26, 2021
@Panquesito7 Panquesito7 deleted the icons/thealgorithms branch February 26, 2021 03:39
@amacado
Copy link
Member

amacado commented Feb 26, 2021

If I configured everything right, than @Panquesito7 should be able to merge into develop and @Thomas-Boi should be able to merge in develop and master. See https://github.com/devicons/devicon/blob/develop/CONTRIBUTING.md#maintainerreviewerteams

@amacado amacado mentioned this pull request Apr 10, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
new icon: TheAlgorithms (original, original-wordmark, plain, plain-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants