Skip to content

Conversation

@amacado
Copy link
Member

@amacado amacado commented Jan 10, 2021

As the result of discussion #470 update guidelines with squash merging

As the result of discussion #470 update guidelines with squash merging
@amacado amacado added enhancement devops Devops/automation related enhancements labels Jan 10, 2021
@amacado amacado requested a review from Thomas-Boi January 10, 2021 15:26
@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Thomas-Boi
Copy link
Member

Everything looks good

@Thomas-Boi Thomas-Boi closed this Jan 10, 2021
@amacado
Copy link
Member Author

amacado commented Jan 10, 2021

@Thomas-Boi when it looks good, why closing this pr? ;-)

@amacado amacado reopened this Jan 10, 2021
@github-actions
Copy link
Contributor

Hi!
I'm Devicons' SVG-Checker Bot and I just checked all the SVGs in this branch.

Everything looks great. Good job!

Have a nice day,
SVG-Checker Bot 😁

@Thomas-Boi Thomas-Boi merged commit c71c518 into develop Jan 11, 2021
@Thomas-Boi
Copy link
Member

Oh my bad 😅. I wanted to merge it. Thanks for catching it. I've been a bit tired trying to fix the commenting issue.

@amacado amacado deleted the amacado/feature/squash-merging-guideline branch January 11, 2021 09:27
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…merging-guideline

Add guideline about squash merging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops Devops/automation related enhancements enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants