Skip to content

Conversation

@Thomas-Boi
Copy link
Member

No description provided.

@Thomas-Boi Thomas-Boi requested a review from amacado December 13, 2020 21:53
@Thomas-Boi Thomas-Boi self-assigned this Dec 13, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is browserconfig.xml required? (And in the right place?)

@Thomas-Boi
Copy link
Member Author

I actually missed that file, thanks for pointing it out to me 😄

I did some research on what it does, turns out it's a Windows thing only

It doesn't do much to the site but it helps prevent errors in IE and Windows 8

So I guess it's not crucial to the site and we can remove it if we want to. As for its location, we just have to put it in the root of the publishing source, so I think in the docs/ folder for our case

@Thomas-Boi
Copy link
Member Author

I've just moved the browserconfig.xml and CNAME file into the docs/ folder. I think it should be correct since docs/ is our publishing source. If needed, we can fix it later.

@Thomas-Boi Thomas-Boi linked an issue Dec 15, 2020 that may be closed by this pull request
12 tasks
@amacado amacado merged commit 8ebba86 into develop Dec 15, 2020
@amacado amacado deleted the TB_ghPage branch December 15, 2020 07:21
@amacado amacado linked an issue Dec 15, 2020 that may be closed by this pull request
amacado added a commit that referenced this pull request Dec 28, 2020
… svg's) to /docs/dist folder allowing them to be used in GitHub page (see #394)
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Moved GitHub pages stuff into a docs/ folder
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
… svg's) to /docs/dist folder allowing them to be used in GitHub page (see devicons#394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix missing font icons (plain/line version) DevOps (CircleCI): build step to publish latest version on Github Pages

3 participants