Skip to content

Conversation

@Thomas-Boi
Copy link
Member

No description provided.

@Thomas-Boi Thomas-Boi linked an issue Dec 11, 2020 that may be closed by this pull request
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Dec 11, 2020

Hi @amacado ,
Seems like the issue has been fixed by this commit. I'll post my analysis in the issue linked to this PR. You can find the pull request created by the bot in the PR menu

Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looking good to me (not tested yet) only a small suggestion in changing some description 🚀

@amacado amacado added bug Use this label for pointing out bugs enhancement labels Dec 11, 2020
Co-authored-by: Clemens Bastian <8781699+amacado@users.noreply.github.com>
@Thomas-Boi Thomas-Boi merged commit 0ca4e3b into develop Dec 12, 2020
@amacado amacado deleted the TB_buildFix branch December 12, 2020 03:51
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
Fix a couple issues found in the build script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Use this label for pointing out bugs enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github action 'Build icons' not working as intended

3 participants