Skip to content

New icon: Woocommerce (original, original-wordmark, plain, plain-wordmark) #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amacado merged 6 commits into from
Oct 31, 2020
Merged

New icon: Woocommerce (original, original-wordmark, plain, plain-wordmark) #340

amacado merged 6 commits into from
Oct 31, 2020

Conversation

@ezSaldana
Copy link
Contributor

@ezSaldana ezSaldana commented Oct 25, 2020

Added Wocommerce icon

I've added the plain, original and wordmarks icons. Give it a check and let me know if there's something I should change.

Image

Screen Shot 2020-10-25 at 16 49 09

Issue Reference

#330

@amacado amacado linked an issue Oct 30, 2020 that may be closed by this pull request
Icon request: Woocommerce #330
Closed
@amacado amacado self-requested a review October 30, 2020 16:17
@amacado amacado added feature:icon PR when a new icon is ready to be added to the collection bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 30, 2020
amacado
amacado requested changes Oct 30, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you can see the icons don't look right when converted to a font. This is probably because you have used multiple colors in it:
st0{fill:#7f54b3;}.st1{fill:#FFFFFF;}

You can try this by yourself when uploading the svg to icomoon.

image

@ezSaldana
Copy link
Contributor Author

ezSaldana commented Oct 30, 2020

Ready, give it a check and let me know if it's ok 👍🏽

@amacado amacado added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Oct 31, 2020
@amacado amacado self-requested a review October 31, 2020 00:58
amacado
amacado approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Nice addition! 👍🏻
image

@amacado amacado merged commit dcaae75 into devicons:develop Oct 31, 2020
@ezSaldana ezSaldana deleted the feature/330-woocommerce branch October 31, 2020 04:16
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@amacado
Merge pull request devicons#340 from ezSaldana/feature/330-woocommerce
2eac4a5 
New icon: Woocommerce (original, original-wordmark, plain, plain-wordmark)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacado amacado amacado approved these changes

Assignees

@ezSaldana ezSaldana

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Icon request: Woocommerce

2 participants

@ezSaldana @amacado